Prolog: add triggers for sins/3 hints

2 files changed, 155 insertions, 8 deletions

diff --git a/prolog/problems/sorting/sins_3/common.py b/prolog/problems/sorting/sins_3/common.py
index a363bac..8be9b6c 100644
--- a/prolog/problems/sorting/sins_3/common.py
+++ b/prolog/problems/sorting/sins_3/common.py
@@ -1,11 +1,11 @@
-# coding=utf-8
-
 from operator import itemgetter
+import socket
+
 import prolog.engine
-import server.problems
+from server.hints import Hint, HintPopup
 
 id = 122
-number = 29
+number = 30
 visible = False
 facts = None
 
@@ -18,6 +18,22 @@ sins(X, [Y|T], [Y|L]) :-
   sins(X, T, L).
 '''
 
+hint_type = {
+    'eq_instead_of_equ_markup': HintPopup('eq_instead_of_equ_markup'),
+    'eq_instead_of_equ': Hint('eq_instead_of_equ'),
+    'predicate_always_false': Hint('predicate_always_false'),
+    'base_case': Hint('base_case'),
+    'recursive_case': Hint('recursive_case'),
+    'timeout': Hint('timeout'),
+    'bad_[]_case': Hint('bad_[]_case'),
+    'returns_elem_instead_of_list': Hint('returns_elem_instead_of_list'),
+    'maxEl_base_case_missing': Hint('maxEl_base_case_missing'),
+    'x_and_head_swapped': Hint('x_and_head_swapped'),
+    'duplicates_incorrect': Hint('duplicates_incorrect'),
+    'unprotected_branch': Hint('unprotected_branch'),
+    'forgotten_heads': Hint('forgotten_heads'),
+}
+
 test_cases = [
     ('sins(4, [], X)',
         [{'X': '[4]'}]),
@@ -51,5 +67,77 @@ def test(code, aux_code):
     return n_correct, len(test_cases), hints
 
 def hint(code, aux_code):
-    # TODO
+    tokens = prolog.util.tokenize(code)
+
+    try:
+        engine_id, output = prolog.engine.create(code=code+aux_code, timeout=1.0)
+
+        # strict equality testing instead of simple matching
+        # this is usually (but not necessarily) wrong
+        targets = [prolog.util.Token('EQ', '==')]
+        marks = [(t.pos, t.pos + len(t.val)) for t in tokens if t in targets]
+        if marks:
+            return [{'id': 'eq_instead_of_equ_markup', 'start': m[0], 'end': m[1]} for m in marks] + \
+                   [{'id': 'eq_instead_of_equ'}]
+
+        if prolog.engine.ask_truthTO(engine_id, '''\
+                sins(yowza, [], [])
+                ;
+                sins(yowza, [], cob(Q, q))'''):
+            return [{'id': 'bad_[]_case'}]
+
+        if prolog.engine.ask_truthTO(engine_id, 'sins(yowza, [], yowza)'):
+            return [{'id': 'returns_elem_instead_of_list'}]
+
+        if prolog.engine.ask_truthTO(engine_id, '''\
+                sins(4, [1, 3, 5, 6], [1, 3, 4, 5, 6]),
+                \+ sins(9, [1, 3, 5, 6], [1, 3, 5, 6, 9]),
+                \+ sins(39, [], [39])'''):
+            return [{'id': 'maxEl_base_case_missing'}]
+
+        if prolog.engine.ask_truthTO(engine_id,
+                'sins(4, [1, 3, 5, 6], [1, 3, 5, 4, 9])'):
+            return [{'id': 'x_and_head_swapped'}]
+
+        if prolog.engine.ask_truthTO(engine_id, '''\
+                sins(4, [1, 3, 5, 6], [1, 3, 4, 5, 6]),
+                \+ sins(5, [1, 3, 5, 6], [1, 3, 5, 5, 6])
+                ;
+                findall(L, sins(5, [1, 3, 5, 6], L),
+                        [[1, 3, 5, 5, 6], [1, 3, 5, 6, 5]])'''):
+            return [{'id': 'duplicates_incorrect'}]
+
+        # incorrect solutions after first one
+        if prolog.engine.ask_truthTO(engine_id, '''\
+                findall(X, sins(4, [1, 2, 3, 5, 6, 7], X),
+                        [[1, 2, 3, 4, 5, 6, 7] | L]),
+                length(L, N), N > 0'''):
+            return [{'id': 'unprotected_branch'}]
+
+        if prolog.engine.ask_truthTO(engine_id, '''\
+                sins(4, [1, 3, 5, 6], [4, 5, 6]),
+                sins(9, [1, 3, 5, 6, 8, 39], [9, 39])'''):
+            return [{'id': 'forgotten_heads'}]
+
+        # missing/failed base case
+        if not prolog.engine.ask_truthTO(engine_id, 'sins(42, [], [42])'):
+            return [{'id': 'base_case'}]
+
+        # target predicate seems to always be false
+        if not prolog.engine.ask_truthTO(engine_id, 'sins(_, _, _)'):
+            return [{'id': 'predicate_always_false'}]
+
+        # base case works, the recursive doesn't (but it doesn't timeout)
+        # this may be left as the last, most generic hint
+        if not prolog.engine.ask_truth(engine_id,
+                'sins(42, [-2, 41, 82, 100], [-2, 41, 42, 82, 100])'):
+            return [{'id': 'recursive_case'}]
+
+    except socket.timeout as ex:
+        return [{'id': 'timeout'}]
+
+    finally:
+        if engine_id:
+            prolog.engine.destroy(engine_id)
+
     return []
diff --git a/prolog/problems/sorting/sins_3/sl.py b/prolog/problems/sorting/sins_3/sl.py
index fe7d015..d2a8ccb 100644
--- a/prolog/problems/sorting/sins_3/sl.py
+++ b/prolog/problems/sorting/sins_3/sl.py
@@ -1,5 +1,3 @@
-# coding=utf-8
-
 name = 'sins/3'
 slug = 'Vstavi element na ustrezno mesto v urejen seznam'
 
@@ -12,4 +10,65 @@ description = '''\
   L = [1,2,3,3,4].
 </pre>'''
 
-hint = {}
+hint = {
+    'eq_instead_of_equ': '''\
+<p>Operator <code>==</code> je strožji od operatorja <code>=</code> v smislu, da je za slednjega dovolj,
+da elementa lahko naredi enaka (unifikacija).</p>
+<p>Seveda pa lahko nalogo rešiš brez obeh omenjenih operatorjev, spomni se, da lahko unifikacijo narediš
+implicitno že kar v argumentih predikata (glavi stavka).</p>
+''',
+
+    'eq_instead_of_equ_markup': '''\
+<p>Morda bi bil bolj primeren operator za unifikacijo (<code>=</code>)?</p>
+''',
+
+    'base_case': '''\
+<p>Si pomislil na robni pogoj? Kaj je najbolj enostaven primer, ko je element v seznamu?
+Do katerega elementa najlažje prideš?</p>
+''',
+
+    'recursive_case': '''\
+<p>Robni primer deluje. Kaj pa rekurzivni, splošni, primer?</p>
+''',
+
+    'predicate_always_false': '''\
+<p>Vse kaže, da tvoj predikat vedno vrne <code>false</code>. Si mu dal pravilno ime, si se morda pri imenu zatipkal?</p>
+<p>Če je ime pravilno, se morda splača preveriti tudi, če se nisi zatipkal kje drugje,
+je morda kakšna pika namesto vejice ali obratno, morda kakšna spremenljivka z malo začetnico?</p>
+<p>Možno je seveda tudi, da so tvoji pogoji prestrogi ali celo nemogoči (kot bi bila npr. zahteva,
+da je <code>X</code> hkrati starš in sestra od <code>Y</code> ali kaj podobno zlobnega).</p>
+''',
+
+    'timeout': '''\
+<p>Je morda na delu potencialno neskončna rekurzija? Kako se bo ustavila?</p>
+<p>Morda pa je kriv tudi manjkajoč, neustrezen ali preprosto nekompatibilen (s splošnim primerom) robni pogoj?</p>
+''',
+
+    'bad_[]_case': '''\
+<p>bad_[]_case</p>
+''',
+
+    'returns_elem_instead_of_list': '''\
+<p>returns_elem_instead_of_list</p>
+''',
+
+    'maxEl_base_case_missing': '''\
+<p>maxEl_base_case_missing</p>
+''',
+
+    'x_and_head_swapped': '''\
+<p>x_and_head_swapped</p>
+''',
+
+    'duplicates_incorrect': '''\
+<p>duplicates_incorrect</p>
+''',
+
+    'unprotected_branch': '''\
+<p>unprotected_branch</p>
+''',
+
+    'forgotten_heads': '''\
+<p>forgotten_heads</p>
+''',
+}