From de500ad6985cab03d034e85a70c5882507082ce4 Mon Sep 17 00:00:00 2001
From: Timotej Lazar <timotej.lazar@fri.uni-lj.si>
Date: Tue, 29 Mar 2016 20:32:43 +0200
Subject: Prolog: add triggers for quick_sort/2 hints

---
 prolog/problems/sorting/quick_sort_2/common.py | 64 ++++++++++++++++++++++++--
 prolog/problems/sorting/quick_sort_2/sl.py     | 44 +++++++++++++++++-
 2 files changed, 102 insertions(+), 6 deletions(-)

diff --git a/prolog/problems/sorting/quick_sort_2/common.py b/prolog/problems/sorting/quick_sort_2/common.py
index 85ababe..8b9bcb7 100644
--- a/prolog/problems/sorting/quick_sort_2/common.py
+++ b/prolog/problems/sorting/quick_sort_2/common.py
@@ -1,11 +1,11 @@
-# coding=utf-8
-
 from operator import itemgetter
+import socket
+
 import prolog.engine
-import server.problems
+from server.hints import Hint, HintPopup
 
 id = 125
-number = 32
+number = 60
 visible = False
 facts = None
 
@@ -28,6 +28,17 @@ quick_sort([Pivot|T], Sorted) :-
   conc125(SortedSmaller, [Pivot|SortedGreater], Sorted).
 '''
 
+hint_type = {
+    'eq_instead_of_equ_markup': HintPopup('eq_instead_of_equ_markup'),
+    'eq_instead_of_equ': Hint('eq_instead_of_equ'),
+    'predicate_always_false': Hint('predicate_always_false'),
+    'base_case': Hint('base_case'),
+    'recursive_case': Hint('recursive_case'),
+    'timeout': Hint('timeout'),
+    'arbitrary_base_case': Hint('arbitrary_base_case'),
+    'forgotten_pivot': Hint('forgotten_pivot'),
+}
+
 test_cases = [
     ('quick_sort([], X)',
         [{'X': '[]'}]),
@@ -59,5 +70,48 @@ def test(code, aux_code):
     return n_correct, len(test_cases), hints
 
 def hint(code, aux_code):
-    # TODO
+    tokens = prolog.util.tokenize(code)
+
+    try:
+        engine_id, output = prolog.engine.create(code=code+aux_code, timeout=1.0)
+
+        # strict equality testing instead of simple matching
+        # this is usually (but not necessarily) wrong
+        targets = [prolog.util.Token('EQ', '==')]
+        marks = [(t.pos, t.pos + len(t.val)) for t in tokens if t in targets]
+        if marks:
+            return [{'id': 'eq_instead_of_equ_markup', 'start': m[0], 'end': m[1]} for m in marks] + \
+                   [{'id': 'eq_instead_of_equ'}]
+
+        if prolog.engine.ask_truthTO(engine_id, 'quick_sort([], [yowza])'):
+            return [{'id': 'arbitrary_base_case'}]
+
+        if prolog.engine.ask_truthTO(engine_id, '''\
+                quick_sort([3, 5, 9, 6, 3, 7, 2], []),
+                asserta(quick_sort([], [q])),
+                quick_sort([3, 5, 9, 6, 3, 7, 2], [q, q, q, q, q, q, q, q]),
+                retract(quick_sort([], [q]))'''):
+            return [{'id': 'forgotten_pivot'}]
+
+        # missing/failed base case
+        if not prolog.engine.ask_truthTO(engine_id, 'quick_sort([], [])'):
+            return [{'id': 'base_case'}]
+
+        # target predicate seems to always be false
+        if not prolog.engine.ask_truthTO(engine_id, 'quick_sort(_, _)'):
+            return [{'id': 'predicate_always_false'}]
+
+        # base case works, the recursive doesn't (but it doesn't timeout)
+        # this may be left as the last, most generic hint
+        if not prolog.engine.ask_truth(engine_id,
+                'quick_sort([41, 82, -2, 100], [-2, 41, 82, 100])'):
+            return [{'id': 'recursive_case'}]
+
+    except socket.timeout as ex:
+        return [{'id': 'timeout'}]
+
+    finally:
+        if engine_id:
+            prolog.engine.destroy(engine_id)
+
     return []
diff --git a/prolog/problems/sorting/quick_sort_2/sl.py b/prolog/problems/sorting/quick_sort_2/sl.py
index 8b6ad94..d37867b 100644
--- a/prolog/problems/sorting/quick_sort_2/sl.py
+++ b/prolog/problems/sorting/quick_sort_2/sl.py
@@ -10,4 +10,46 @@ description = '''\
   L = [1,2,3,4,5].
 </pre>'''
 
-hint = {}
+hint = {
+    'eq_instead_of_equ': '''\
+<p>Operator <code>==</code> je strožji od operatorja <code>=</code> v smislu, da je za slednjega dovolj,
+da elementa lahko naredi enaka (unifikacija).</p>
+<p>Seveda pa lahko nalogo rešiš brez obeh omenjenih operatorjev, spomni se, da lahko unifikacijo narediš
+implicitno že kar v argumentih predikata (glavi stavka).</p>
+''',
+
+    'eq_instead_of_equ_markup': '''\
+<p>Morda bi bil bolj primeren operator za unifikacijo (<code>=</code>)?</p>
+''',
+
+    'base_case': '''\
+<p>Si pomislil na robni pogoj? Kaj je najbolj enostaven primer, ko je element v seznamu?
+Do katerega elementa najlažje prideš?</p>
+''',
+
+    'recursive_case': '''\
+<p>Robni primer deluje. Kaj pa rekurzivni, splošni, primer?</p>
+''',
+
+    'predicate_always_false': '''\
+<p>Vse kaže, da tvoj predikat vedno vrne <code>false</code>. Si mu dal pravilno ime, si se morda pri imenu zatipkal?</p>
+<p>Če je ime pravilno, se morda splača preveriti tudi, če se nisi zatipkal kje drugje,
+je morda kakšna pika namesto vejice ali obratno, morda kakšna spremenljivka z malo začetnico?</p>
+<p>Možno je seveda tudi, da so tvoji pogoji prestrogi ali celo nemogoči (kot bi bila npr. zahteva,
+da je <code>X</code> hkrati starš in sestra od <code>Y</code> ali kaj podobno zlobnega).</p>
+''',
+
+    'timeout': '''\
+<p>Je morda na delu potencialno neskončna rekurzija? Kako se bo ustavila?</p>
+<p>Morda pa je kriv tudi manjkajoč, neustrezen ali preprosto nekompatibilen (s splošnim primerom) robni pogoj?</p>
+''',
+
+    'arbitrary_base_case': '''\
+<p>arbitrary_base_case</p>
+''',
+
+    'forgotten_pivot': '''\
+<p>forgotten_pivot</p>
+''',
+
+}
-- 
cgit v1.2.1