From 0d32abe688f0636988090f653f75bc33616ad610 Mon Sep 17 00:00:00 2001 From: Timotej Lazar Date: Tue, 29 Mar 2016 19:00:23 +0200 Subject: Prolog: add triggers for is_sorted/1 hints --- prolog/problems/sorting/is_sorted_1/common.py | 95 +++++++++++++++++++++++++-- prolog/problems/sorting/is_sorted_1/sl.py | 61 ++++++++++++++++- 2 files changed, 148 insertions(+), 8 deletions(-) (limited to 'prolog/problems/sorting') diff --git a/prolog/problems/sorting/is_sorted_1/common.py b/prolog/problems/sorting/is_sorted_1/common.py index 0e8a49d..dc97712 100644 --- a/prolog/problems/sorting/is_sorted_1/common.py +++ b/prolog/problems/sorting/is_sorted_1/common.py @@ -1,11 +1,11 @@ -# coding=utf-8 - from operator import itemgetter +import socket + import prolog.engine -import server.problems +from server.hints import Hint, HintPopup id = 121 -number = 28 +number = 10 visible = False facts = None @@ -17,6 +17,21 @@ is_sorted([H1,H2|T]) :- is_sorted([H2|T]). ''' +hint_type = { + 'eq_instead_of_equ_markup': HintPopup('eq_instead_of_equ_markup'), + 'eq_instead_of_equ': Hint('eq_instead_of_equ'), + 'predicate_always_false': Hint('predicate_always_false'), + 'base_case': Hint('base_case'), + 'recursive_case': Hint('recursive_case'), + 'timeout': Hint('timeout'), + '[]_base_case_missing': Hint('[]_base_case_missing'), + 'duplicates_fail': Hint('duplicates_fail'), + 'H1_instead_of_H2_sent_into_recursion': Hint('H1_instead_of_H2_sent_into_recursion'), + 'base_case_at_len_1_missing': Hint('base_case_at_len_1_missing'), + 'both_heads_omitted_from_recursion': Hint('both_heads_omitted_from_recursion'), + 'min_used': Hint('min_used'), +} + test_cases = [ ('is_sorted([])', [{}]), @@ -32,6 +47,8 @@ test_cases = [ [{}]), ('\+ is_sorted([3, 4, 5, 6, 1, 2, 3, 0])', [{}]), + ('\+ is_sorted([3, 13, 6, 39])', + [{}]), ] def test(code, aux_code): @@ -54,5 +71,73 @@ def test(code, aux_code): return n_correct, len(test_cases), hints def hint(code, aux_code): - # TODO + tokens = prolog.util.tokenize(code) + + try: + engine_id, output = prolog.engine.create(code=code+aux_code, timeout=1.0) + + # strict equality testing instead of simple matching + # this is usually (but not necessarily) wrong + targets = [prolog.util.Token('EQ', '==')] + marks = [(t.pos, t.pos + len(t.val)) for t in tokens if t in targets] + if marks: + return [{'id': 'eq_instead_of_equ_markup', 'start': m[0], 'end': m[1]} for m in marks] + \ + [{'id': 'eq_instead_of_equ'}] + + if prolog.engine.ask_truthTO(engine_id, '''\ + is_sorted([1, 3, 5, 6, 9]), + \+ is_sorted([1, 9, 3, 6]), + is_sorted([39]), + \+ is_sorted([])'''): + return [{'id': '[]_base_case_missing'}] + + # H1 < H2 instead of H1 =< H2 + if prolog.engine.ask_truthTO(engine_id, '''\ + is_sorted([1, 3, 5, 6, 9]), + \+ is_sorted([1, 9, 3, 6]), + \+ is_sorted([1, 3, 5, 5, 7, 9])'''): + return [{'id': 'duplicates_fail'}] + + if prolog.engine.ask_truthTO(engine_id, '''\ + \+ is_sorted([3, 13, 1, 39]), + is_sorted([3, 13, 16, 39]), + is_sorted([3, 13, 6, 39])'''): + return [{'id': 'H1_instead_of_H2_sent_into_recursion'}] + + if prolog.engine.ask_truthTO(engine_id, '''\ + (is_sorted([13, 39]) + ; + is_sorted([])), + \+ is_sorted([39])'''): + return [{'id': 'base_case_at_len_1_missing'}] + + if prolog.engine.ask_truthTO(engine_id, '''\ + \+ is_sorted([1, 0, 2, 25, 39]), + is_sorted([1, 3, 9, 16, 39]), + is_sorted([1, 3, 2, 16, 39])'''): + return [{'id': 'both_heads_omitted_from_recursion'}] + + if any(t.val == 'min' for t in tokens): + return [{'id': 'min_used'}] + + # missing/failed base case + if not prolog.engine.ask_truthTO(engine_id, 'is_sorted([])'): + return [{'id': 'base_case'}] + + # target predicate seems to always be false + if not prolog.engine.ask_truthTO(engine_id, 'is_sorted(_)'): + return [{'id': 'predicate_always_false'}] + + # base case works, the recursive doesn't (but it doesn't timeout) + # this may be left as the last, most generic hint + if not prolog.engine.ask_truth(engine_id, 'is_sorted([-2, 41, 82, 100])'): + return [{'id': 'recursive_case'}] + + except socket.timeout as ex: + return [{'id': 'timeout'}] + + finally: + if engine_id: + prolog.engine.destroy(engine_id) + return [] diff --git a/prolog/problems/sorting/is_sorted_1/sl.py b/prolog/problems/sorting/is_sorted_1/sl.py index a1429d3..d4cd999 100644 --- a/prolog/problems/sorting/is_sorted_1/sl.py +++ b/prolog/problems/sorting/is_sorted_1/sl.py @@ -1,5 +1,3 @@ -# coding=utf-8 - name = 'is_sorted/1' slug = 'Preveri, če so elementi seznama naraščajoče urejeni' @@ -12,4 +10,61 @@ description = '''\ false. ''' -hint = {} +hint = { + 'eq_instead_of_equ': '''\ +

Operator == je strožji od operatorja = v smislu, da je za slednjega dovolj, +da elementa lahko naredi enaka (unifikacija).

+

Seveda pa lahko nalogo rešiš brez obeh omenjenih operatorjev, spomni se, da lahko unifikacijo narediš +implicitno že kar v argumentih predikata (glavi stavka).

+''', + + 'eq_instead_of_equ_markup': '''\ +

Morda bi bil bolj primeren operator za unifikacijo (=)?

+''', + + 'base_case': '''\ +

Si pomislil na robni pogoj? Kaj je najbolj enostaven primer, ko je element v seznamu? +Do katerega elementa najlažje prideš?

+''', + + 'recursive_case': '''\ +

Robni primer deluje. Kaj pa rekurzivni, splošni, primer?

+''', + + 'predicate_always_false': '''\ +

Vse kaže, da tvoj predikat vedno vrne false. Si mu dal pravilno ime, si se morda pri imenu zatipkal?

+

Če je ime pravilno, se morda splača preveriti tudi, če se nisi zatipkal kje drugje, +je morda kakšna pika namesto vejice ali obratno, morda kakšna spremenljivka z malo začetnico?

+

Možno je seveda tudi, da so tvoji pogoji prestrogi ali celo nemogoči (kot bi bila npr. zahteva, +da je X hkrati starš in sestra od Y ali kaj podobno zlobnega).

+''', + + 'timeout': '''\ +

Je morda na delu potencialno neskončna rekurzija? Kako se bo ustavila?

+

Morda pa je kriv tudi manjkajoč, neustrezen ali preprosto nekompatibilen (s splošnim primerom) robni pogoj?

+''', + + '[]_base_case_missing': '''\ +

[]_base_case_missing

+''', + + 'duplicates_fail': '''\ +

duplicates_fail

+''', + + 'H1_instead_of_H2_sent_into_recursion': '''\ +

H1_instead_of_H2_sent_into_recursion

+''', + + 'base_case_at_len_1_missing': '''\ +

base_case_at_len_1_missing

+''', + + 'both_heads_omitted_from_recursion': '''\ +

both_heads_omitted_from_recursion

+''', + + 'min_used': '''\ +

min_used

+''', +} -- cgit v1.2.1