summaryrefslogtreecommitdiff
path: root/kpov_judge/tasks/openvpn_simple_smb/task.py
diff options
context:
space:
mode:
Diffstat (limited to 'kpov_judge/tasks/openvpn_simple_smb/task.py')
-rw-r--r--kpov_judge/tasks/openvpn_simple_smb/task.py10
1 files changed, 7 insertions, 3 deletions
diff --git a/kpov_judge/tasks/openvpn_simple_smb/task.py b/kpov_judge/tasks/openvpn_simple_smb/task.py
index 705eb18..0b497ca 100644
--- a/kpov_judge/tasks/openvpn_simple_smb/task.py
+++ b/kpov_judge/tasks/openvpn_simple_smb/task.py
@@ -188,7 +188,8 @@ def task(IP_SimpleArbiterVPN, DNS_SimpleArbiterVPN, IP_VPNClient1, DNS_VPNClient
######
# sA
######
-
+ # TODO: (polz) you can remove nmcli and nslookup - these were only used in the task that
+ # was used as the template for other taps
# Make sure NM is not handling eth0
results['SimpleArbiter_nmcli'] = sA.run('nmcli d')
@@ -230,6 +231,8 @@ def task(IP_SimpleArbiterVPN, DNS_SimpleArbiterVPN, IP_VPNClient1, DNS_VPNClient
# really, really hoping it has root privileges too
###
### Install nmap
+ # TODO: (polz) Don't install nmap here - tell me that you
+ # need nmap to be present on simpleArbiter and I'll install it.
# Check if root
sA.sendline('id -u')
sA.prompt()
@@ -266,7 +269,7 @@ def task(IP_SimpleArbiterVPN, DNS_SimpleArbiterVPN, IP_VPNClient1, DNS_VPNClient
######
# sC1
######
-
+ # TODO: (polz) again, no need for this
results['VPNClient1_nmcli'] = sC1.run('nmcli d')
results['VPNClient1_nslookup'] = sC1.run('nslookup www.arnes.si')
@@ -297,7 +300,8 @@ def task(IP_SimpleArbiterVPN, DNS_SimpleArbiterVPN, IP_VPNClient1, DNS_VPNClient
sA.logout()
sC1.logout()
sC2.logout()
-
+ # TODO: (polz) please, add some sort of check to verify that the user created the neccessarry keys.
+ #
return results